[NO SQUASH] Create translate template and translate. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @Montandalar (fixes a few points in #90) |
SmallJoker
reviewed
Nov 25, 2023
Comment on lines
+3
to
+4
| -- local MP = minetest.get_modpath(minetest.get_current_modname()) | ||
| -- local S = dofile(MP.."/intllib.lua") |
There was a problem hiding this comment.
Feel free to remove those. They're no longer needed as Minetest's translation works pretty well so far and might even get .po (gettext) support in the future.
SmallJoker
changed the title
|
Looks good overall. Thank you very much for this change. After my comment above is addressed - regardless whether you'd like to change it or not - I would then this PR a few days afterwards unless there are objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.