Skip to content

Conversation

@sfence
Copy link
Contributor

@sfence sfence commented Jun 13, 2025

Integrate support for Hades Revisited into the Mesecons modpack, allowing it to tag https://content.luanti.org/packages/SFENCE/hades_mesecons/ as obsolete.

name = mesecons_gamecompat
depends = mesecons
optional_depends = fire, default, dye, mesecons_mvps, tnt, doors, beds, mcl_fire, mcl_core, mcl_dye, mcl_tnt
optional_depends = fire, default, dye, mesecons_mvps, tnt, doors, beds, mcl_fire, mcl_core, mcl_dye, mcl_tnt, hades_core, hades_sounds, hades_torches, hades_doors, hades_beds, hades_fire, hades_tnt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically you only need to depend on hades_sounds. Everything else is only accessed after all mods have finished loading.
The same holds true for the mcl_ * mods, but touching that is out of scope of this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably also valid for fire, dye, tnt, doors and beds mod from Minetest game.

Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to adjust the dependencies - I however do not consider this a requirement.

Will merge in a few days unless there are objections.

@SmallJoker SmallJoker merged commit e2fc73d into minetest-mods:master Jun 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants