Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: make skins.register_skin public #106

Merged
merged 2 commits into from
Jul 7, 2024
Merged

Conversation

SmallJoker
Copy link
Member

Fixes #102

@Bastrabun Please feel free to provide feedback. Does it work as you'd expect?

@Bastrabun
Copy link

For the usecase of having a separate mod govern the real textures: yes. I didn't do a full test including meta and everything though.

For the usecase of retrofitting skins into a running server: No, because the hand apparently registers a block of its own. I do not have a suggestion on how to prevent this or do it differently, for my retrofitting attempt I will most likely overwrite this function and replace it with one that temporarily registers a "default" hand until the next server restart.

Also to be noted: Servers that import the whole skins database and have an awesome 250 pages of skins to select from also require 250 x 16 = 4000 nodedefinitions they must expend

@SmallJoker
Copy link
Member Author

For the usecase of retrofitting skins into a running server:

Media files must also be known after on_mods_loaded so that they can be distributed to players - unless delayed media sending is used, which is yet not supported by all common clients.

I'll go ahead and merge this PR in a week unless there's objections.

@SmallJoker SmallJoker merged commit b7cd514 into master Jul 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please make process_skin_texture a public function
2 participants