-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log bucket liquid placement #3108
Log bucket liquid placement #3108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine. text
in log_action
should probably be called something like action
? Reordering the parameters to be in the order the message is built (roughly "<name> did <action> at <pos>") could also help make this slightly more readable IMO.
I can definitely see the logging for placing liquids being useful against griefers.
(Why log picking up liquids though?)
Tested briefly, does what it says on the tin, doesn't blow up.
I'm not sure if this technically counts as maintenance, but adding some more logging is by no means problematic.
I kept the order mostly for consistency with the
Like the engine log digging node, IMO logging this is also needed. |
This PR ports minetest/minetest_game#3108 to wooden buckets. It logs liquid placement and removal. This PR is ready for review.
This PR adds code to log liquid placements done via buckets. Previously, only failed attempts were logged.
This PR is ready for review.