Simplify Butterfly and Firefly codes #3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is what I was told when I tried this: #3093 (comment) |
I started the timer in an on_construct callback. |
|
I will close my PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the code of butterflies and fireflies. Changes are listed below:
on_constructcallback is added to handle node timers.tool_capabilitiesfield to handle bug-catching. As a side effect, the capabilities of the bare hands are inherited.As the typical node placing and digging routines are used, placements are logged and protection violation callbacks are called.
This PR conflicts with #3116. That PR still uses custom code, and this PR replaces those with the engine's routines.
Fixes #2987 by using the engine's routine. Unlike #3116, this PR does not fix #3102 as it is another unrelated issue.
This PR is ready for review.