Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new recipe for strings from any wool block #3136

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

M4urus
Copy link

@M4urus M4urus commented Jun 23, 2024

It would make mods such as Animalia(creating saddles require strings) or any bow/crossbow mod integrate much more naturally to MTG, since cotton is very hard to find, or impossible depending on the biome.

Also this recipe makes a lot of sense IMO.

Added new strings recipe.
@M4urus
Copy link
Author

M4urus commented Jun 23, 2024

Sorry, this is my first contrib. I don't get the issue with the white space, could somebody help me with that? I've seen recent PRs with white spaces added and there was no warning in luacheck.

mods/wool/init.lua Outdated Show resolved Hide resolved
Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether we can accept this. I'm afraid we might have to view this as a feature and reject it accordingly - it changes game mechanics, even if only slightly.

If this is unanimously considered a good idea, I'd be open to it however.

@SmallJoker
Copy link
Member

This change makes sense from a real-world standpoint. Spinning wool is a common practice. Optimally we'd require a tool to wear out (there's currently nothing that would match in MTG), and time if we wanted to follow reality. Strings might still be easier to obtain by farming cotton - depending on the automation mods that are available.

I wouldn't be opposed to such change. Perhaps adding a loss (3 strings instead of 4) could artificially make cotton more attractive - or mods that add appropriate tools including a wool spinning wheel for lossless conversion.

@sfan5
Copy link
Member

sfan5 commented Nov 9, 2024

@M4urus do you have time to address the comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants