Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated get_metadata() calls #3142

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Replace deprecated get_metadata() calls #3142

merged 1 commit into from
Jul 27, 2024

Conversation

Niklp09
Copy link
Contributor

@Niklp09 Niklp09 commented Jul 15, 2024

Trivial.

appgurueu
appgurueu reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@appgurueu appgurueu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible. Is it documented anywhere that key "" gives you the legacy metadata? (If not, then we should fix that in the engine docs.)

@Niklp09
Copy link
Contributor Author

Niklp09 commented Jul 17, 2024

No, that‘s currently not documented.

@sfan5 sfan5 added the Bugfix label Jul 18, 2024
@sfan5 sfan5 merged commit 88ecab3 into minetest:master Jul 27, 2024
2 checks passed
@appgurueu
Copy link
Contributor

No, that‘s currently not documented.

Alright, documented in minetest/minetest@90fccc1

MoNTE48 pushed a commit to MoNTE48/minetest_game that referenced this pull request Aug 17, 2024
@Niklp09 @MoNTE48
Replace deprecated get_metadata() calls (minetest#3142)
47b436a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu left review comments

@sfan5 sfan5 sfan5 approved these changes

Assignees
No one assigned
Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Niklp09 @appgurueu @sfan5