Skip to content

Allow Described types in SimpleValue to enable interoperability with .Net EventHubs client #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LarryOsterman
Copy link
Contributor

Fixes #311

@minghuaw minghuaw merged commit 9ac4579 into minghuaw:main May 8, 2025
3 checks passed
@minghuaw
Copy link
Owner

minghuaw commented May 8, 2025

LGTM!

@LarryOsterman
Copy link
Contributor Author

LGTM!

TYVM. And yeah, this one was really surprising to me when the SDK for Python folks showed me the trace. And then to discover that there's a set of magic elements that aren't documented which get converted differently was also a surprise.

FWIW, the EventHubs client for Go won't do the conversions - they treat them as a private enumeration and nobody has mentioned that it's a problem (OTOH, the Python team ran into an issue where someone added a DateTimeOffset in .Net, it was converted to a described type , but when Python tried to map it back to the Python DateTimeOffset type, the Python version couldn't handle the representation of the .Net value (there's a similar problem in Rust EventHubs with the -62_135_596_800_000 value - that was fun because it worked fine on some Linux devices but failed miserably on Windows)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimpleValue does not support AMQP Described types.
2 participants