Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update new services for AWS #1026

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Update new services for AWS #1026

merged 5 commits into from
Oct 15, 2024

Conversation

tvqphuoc01
Copy link
Collaborator

@tvqphuoc01 tvqphuoc01 commented Oct 8, 2024 •
edited
Loading

Introduce additional services for AWS:

  1. OpenSearch
  2. CodeArtifact
  3. DevOps Guru
  4. Network Firewall
  5. Proton
  6. AppConfig
  7. Amazon Managed Grafana
  8. Amazon Managed Prometheus
  9. AWS Managed Workflow for Apache Airflow

@tvqphuoc01 tvqphuoc01 added the area/provider/aws AWS provider label Oct 8, 2024
@tvqphuoc01 tvqphuoc01 self-assigned this Oct 8, 2024
This was linked to issues Oct 8, 2024
Icon for aws appConfig #760
Closed
Include full AWS asset package of icons #764
Closed
Icon Request - Amazon Managed Grafana and Amazon Managed Prometheus #908
Closed
Add AWS Managed Workflow for Airflow Apache #977
Closed
@tvqphuoc01 tvqphuoc01 marked this pull request as ready for review October 9, 2024 16:47
gabriel-tessier
gabriel-tessier requested changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@gabriel-tessier gabriel-tessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look fine except the proton file which is 500x500 should be 256x256

@tvqphuoc01
Copy link
Collaborator Author

look fine except the proton file which is 500x500 should be 256x256

updated the size of Proton. Thanks

gabriel-tessier
gabriel-tessier requested changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@gabriel-tessier gabriel-tessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments for the icons naming.

diagrams/aws/analytics.py Outdated Show resolved Hide resolved
diagrams/aws/devtools.py Show resolved Hide resolved
diagrams/aws/management.py Outdated Show resolved Hide resolved
@tvqphuoc01 tvqphuoc01 merged commit ed44fdb into master Oct 15, 2024
5 checks passed
@tvqphuoc01 tvqphuoc01 deleted the Issue-977-update-new-aws-services-icons branch October 15, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipeaaoliveira filipeaaoliveira filipeaaoliveira approved these changes

@gabriel-tessier gabriel-tessier gabriel-tessier approved these changes

Assignees

@tvqphuoc01 tvqphuoc01

Labels
area/provider/aws AWS provider
Projects
None yet
Milestone
No milestone
3 participants
@tvqphuoc01 @gabriel-tessier @filipeaaoliveira