Skip to content

Conversation

aoki-h-jp
Copy link
Contributor

feat(aws): add AWS Security Lake icon

Summary

This PR adds the AWS Security Lake icon to the diagrams library, enabling users to create comprehensive diagrams with AWS security data lake components for centralized security data management and analysis.

Changes

  • ✅ Added Security Lake icon and SecurityLake class
  • ✅ Updated diagrams/aws/security.py with new class via autogen
  • ✅ Included proper icon sizing and formatting

New Classes Available

from diagrams.aws.security import SecurityLake

# Example usage
with Diagram("AWS Security Architecture", show=False):
    # Security data lake
    security_lake = SecurityLake("Security Lake")
    
    # Integration with other security services
    guardduty = Guardduty("GuardDuty")
    security_hub = SecurityHub("Security Hub")
    macie = Macie("Macie")
    
    # Data flow to Security Lake
    [guardduty, security_hub, macie] >> security_lake

Testing

  • ✅ Icons render correctly in test diagrams
  • ✅ No existing functionality broken
  • ✅ All imports work correctly
  • ✅ Visual validation completed
  • ✅ Autogen script executed successfully

Icon Sources

Icon sourced from AWS official Security Lake service icon:

  • security-lake.svg → security-lake.png (256x256 pixels)

Implementation Details

  • Icon Format: PNG, properly sized (256x256) for diagram rendering
  • Naming Convention: kebab-case for files, PascalCase for classes
  • Generation Method: Used ./autogen.sh workflow following contribution guidelines
  • Code Formatting: Applied black formatting for consistency
  • Module: Added to diagrams.aws.security (appropriate for security services)

Validation Results

# Autogen script execution
$ export PATH=$PATH:$(go env GOPATH)/bin && ./autogen.sh
✅ SVG converted to PNG successfully
✅ Security Lake class generated automatically
✅ Code formatting applied with black
✅ All existing tests pass

Checklist

  • ✅ Icon is properly formatted and sized for diagram rendering
  • ✅ Naming follows established conventions (kebab-case → PascalCase)
  • ✅ ./autogen.sh executed successfully
  • ✅ No breaking changes introduced
  • ✅ Code formatted with black
  • ✅ Follows existing contribution patterns
  • ✅ Manual edits avoided - used autogen workflow

PR Type: Enhancement
Breaking Changes: None
Documentation: Implementation follows contribution guidelines
Icons Source: AWS Official Security Lake Icon

Copy link
Collaborator

@gabriel-tessier gabriel-tessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aoki-h-jp

Thanks for the contribution.

@gabriel-tessier gabriel-tessier merged commit 72b8c9b into mingrammer:master Aug 23, 2025
8 checks passed
@aoki-h-jp aoki-h-jp deleted the feature/add-aws-security-lake-icon branch August 23, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/provider/aws AWS provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants