Skip to content

Conversation

feorlen
Copy link
Collaborator

@feorlen feorlen commented Aug 14, 2025

Document mc share upload --content-type. Thank you @0xMALVEE 🎉

Staged:
https://staging.docs.min.dev/community/minio-object-store/aistor-214-mc-share/reference/minio-mc/mc-share-upload.html

Questions for reviewers:

  • Is the text appropriately phrased for those knowledgeable of things HTTP?
  • Can you specify more than one accepted type?

See https://github.com/miniohq/aistor-object-store-docs/issues/214 for parent issue

mc share upload --recursive play/mybucket/myprefix/
.. mc-cmd:: --content-type, T
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if you can specify more than one accepted content type with multiple --content-type arguments

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per eng, you can only specify one

If configured, clients using the generated URL must include a ``Content-Type`` header for the specified type.
MinIO rejects requests that do not have the correct ``Content-Type`` header.

Content types are also known as `media types <https://www.iana.org/assignments/media-types/media-types.xhtml>`__.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am being pedantic.

Copy link

Copy link

@feorlen feorlen requested a review from 0xMALVEE August 14, 2025 20:33
Copy link

@0xMALVEE 0xMALVEE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. approved

@djwfyi djwfyi merged commit 779f594 into main Aug 15, 2025
1 check passed
@djwfyi djwfyi deleted the aistor-214-mc-share branch August 15, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants