Skip to content

minor issues #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2025
Merged

minor issues #149

merged 1 commit into from
Apr 26, 2025

Conversation

HJLebbink
Copy link
Member

@HJLebbink HJLebbink commented Apr 24, 2025

Some minor issues that came up while writing docs

@HJLebbink HJLebbink requested a review from Copilot April 24, 2025 23:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a series of minor issues, including standardizing remove_object calls, improving error messages and type annotations, and replacing literal numeric constants with defined constants for consistency.

  • Updated tests to use consistent reference types (e.g. &object_name) when calling remove_object.
  • Added explicit type annotations to header maps and replaced hardcoded ranges with MAX_MULTIPART_COUNT constant in builder functions.
  • Removed deprecated error variants and standardized string comparisons in response handling.

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_put_object.rs Standardized remove_object calls and updated response assertions.
tests/test_object_put.rs Updated remove_object invocation to use &object_name consistently.
tests/test_append_object.rs Same as above—the remove_object call now passes &object_name.
src/s3/utils.rs Returned a reference for element name instead of converting to a String.
src/s3/response/put_object.rs Replaced manual extraction of bucket/object with helper functions.
src/s3/response/* Added type annotations for headers and improved error message comparisons.
src/s3/error.rs Removed deprecated error variants and commented code.
src/s3/client/stat_object.rs Updated function signature to use distinct generic parameters.
src/s3/builders/*.rs Replaced hardcoded values with MAX_MULTIPART_COUNT and improved error messages.

@HJLebbink HJLebbink added the enhancement New feature or request label Apr 24, 2025
@HJLebbink HJLebbink requested a review from donatello April 25, 2025 07:40
@donatello donatello merged commit 1869cfe into minio:master Apr 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants