addon for prometheus in openshift 3.7

[durandom]

fixes #50 prometheus for openshift 3.7

[durandom]

cc @jorgemoralespou as its based on your work
ideally this could be in the prometheus addon, but that does conflict with prometheus on 3.6

[jorgemoralespou]

@durandom there's now the ability to remove an add-on easily by creating an xxx.addon.remove file with instructions to delete the add-on. I still need to update the ones I created.

With regards to the differences to the 3.6 version, are they all in the yaml files or is it also in the install process?

[durandom]

With regards to the differences to the 3.6 version, are they all in the yaml files or is it also in the install process?

I also need to install the node-exporter.

oc create -f node-exporter.yaml -n #{prometheus_namespace}
oc adm policy add-scc-to-user -z prometheus-node-exporter -n #{prometheus_namespace} hostaccess

[durandom]

I've added the .remove file

[praveenkumar]

@jorgemoralespou does this look good to you now?

[durandom]

I'm still not so sure on wether a new addon is actually needed.
But I only see a way to move this into the original addon, by moving some logic out of the .addon file and requiring the user to run a script after installation, which is a convenience degradation?!

@praveenkumar are there discussions on executing shell scripts in the .addon file? This way we could move some conditional logic into a shell script

[praveenkumar]

are there discussions on executing shell scripts in the .addon file?

Check minishift/minishift#1783 but we are not going to have bash script execution support in the addon.

[jorgemoralespou]

Should we need to keep the addon working for 3.6 when minishift has already moved to 3.7?

[durandom]

maybe not. I'll create a new PR to update your original addon to be working with 3.7 then

[coolbrg]

Should we need to keep the addon working for 3.6 when minishift has already moved to 3.7?

@jorgemoralespou

We have not moved to 3.7 yet. PR is there minishift/minishift#1808 but getting some issue.

[LalatenduMohanty]

The addon name is "prometheus-3.7", shouldn't it be just "prometheus"? I saw that we already have a "prometheus" add-on, so why is this required as a separate add-on i.e. why we can update the existing "prometheus" add-on?

[LalatenduMohanty]

I'm still not so sure on wether a new addon is actually needed.
But I only see a way to move this into the original addon, by moving some logic out of the .addon file and requiring the user to run a script after installation, which is a convenience degradation?!

I see. @jorgemoralespou are you ok with this?

[LalatenduMohanty]

Add-on names are decided from the directory names of the add-on, so the name of the add-on for this PR is prometheus-3.7. But the readme says that the name is prometheus. So I am little confused.

[gbraad]

any updates?