Issue #64 build, pull and push of container images #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - dnf install -y docker make git gettext | ||
| - docker login -u gbraad -p $DOCKER_PASSWORD |
There was a problem hiding this comment.
We should get the user name from the environment variable e.g. $DOCKER_USER
|
@gbraad To make this PR to work , we first need to push the intermediate images to github, right? |
| @@ -31,22 +31,25 @@ docker run $DOCKER_RUN_OPTIONS jpetazzo/nsenter cat /nsenter > $tmpdir/nsenter & | |||
| # do not remove nsenter, as this image is not big, and quite generally used | |||
|
|
|||
| # Get socat | |||
| docker build -t socat -f Dockerfile.socat . | |||
| docker run $DOCKER_RUN_OPTIONS socat cat socat > $tmpdir/socat | |||
| [ "${BUILD_CONTAINER_IMAGES+1}" ] && docker build -t minishift/b2d-socat -f Dockerfile.socat . | |||
There was a problem hiding this comment.
Why the +1 in ${BUILD_CONTAINER_IMAGES+1} . If anyone wants to build the images locally we can set export BUILD_CONTAINER_IMAGES=1, right?
|
AFAIR this is to force a truth check. If you have another option that works
from the dind based shell, let me know. They do not use bash... and this
works accross the board with dind images and our CI option
…On Tue, Apr 24, 2018 at 3:55 PM, Lalatendu Mohanty ***@***.*** > wrote:
***@***.**** commented on this pull request.
------------------------------
In iso/build.sh
<#80 (comment)>
:
> @@ -31,22 +31,25 @@ docker run $DOCKER_RUN_OPTIONS jpetazzo/nsenter cat /nsenter > $tmpdir/nsenter &
# do not remove nsenter, as this image is not big, and quite generally used
# Get socat
-docker build -t socat -f Dockerfile.socat .
-docker run $DOCKER_RUN_OPTIONS socat cat socat > $tmpdir/socat
+[ "${BUILD_CONTAINER_IMAGES+1}" ] && docker build -t minishift/b2d-socat -f Dockerfile.socat .
Why the +1 in ${BUILD_CONTAINER_IMAGES+1} . If anyone wants to build the
images locally we can set export BUILD_CONTAINER_IMAGES=1, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#80 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAHZmydbjwyTqST2TPbOxhKoF9oAm4Kks5trtpdgaJpZM4RMSTL>
.
--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]
|
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #64
Will have to remove/replace
but this is something I used before to prevent the rebuild of the images for socat, ethtool, etc