Skip to content

Feature/api server token nonces #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature/api server token nonces #1906

wants to merge 3 commits into from

Conversation

OBorce
Copy link
Contributor

@OBorce OBorce commented Apr 10, 2025

  • add Token next_nonce to token endpoint
  • fix token decimals for mint TxInput

@OBorce OBorce force-pushed the feature/api-server-token-nonces branch from 23c71f4 to f9dbc8a Compare April 21, 2025 08:53
ImplOfAnImpl
ImplOfAnImpl approved these changes Apr 23, 2025
View reviewed changes
api-server/web-server/src/api/json_helpers.rs
@@ -349,7 +353,7 @@ pub fn tx_input_to_json(inp: &TxInput, chain_config: &ChainConfig) -> serde_json
"input_type": "AccountCommand",
"command": "MintTokens",
"token_id": Address::new(chain_config, *token_id).expect("addressable").to_string(),
"amount": amount_to_json(*amount, chain_config.coin_decimals()),
"amount": amount_to_json(*amount, token_decimals.get(token_id)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to add a test for this fix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added test

@OBorce OBorce force-pushed the feature/api-server-token-nonces branch from e994ea6 to bc1e9ed Compare May 6, 2025 07:09
@OBorce OBorce force-pushed the feature/api-server-token-nonces branch from bc1e9ed to 45a8920 Compare May 6, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImplOfAnImpl ImplOfAnImpl ImplOfAnImpl approved these changes

@azarovh azarovh azarovh approved these changes

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OBorce @ImplOfAnImpl @azarovh