Skip to content

fix api server Burn output and tx inspect freezable #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: feature/api-server-token-nonces
Choose a base branch
from
Open

fix api server Burn output and tx inspect freezable #1911

wants to merge 3 commits into from

Conversation

OBorce
Copy link
Contributor

@OBorce OBorce commented Apr 21, 2025

  • Fix Burn output json helpers type
  • Fix wallet CLI tx summary for token freezable status

@OBorce OBorce force-pushed the fix/api-server-burn-output branch from e235cac to 2b9ba26 Compare April 21, 2025 08:53
@OBorce OBorce changed the base branch from master to feature/api-server-token-nonces April 21, 2025 08:54
ImplOfAnImpl
ImplOfAnImpl approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@ImplOfAnImpl ImplOfAnImpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some tests for the fixes

@OBorce OBorce force-pushed the fix/api-server-burn-output branch from 2b9ba26 to 6900a03 Compare April 30, 2025 15:45
@OBorce OBorce marked this pull request as draft April 30, 2025 15:46
@OBorce OBorce force-pushed the fix/api-server-burn-output branch 3 times, most recently from 10fc050 to 477ea98 Compare May 1, 2025 11:46
@OBorce OBorce force-pushed the feature/api-server-token-nonces branch from e994ea6 to bc1e9ed Compare May 6, 2025 07:09
@OBorce OBorce force-pushed the fix/api-server-burn-output branch from 477ea98 to 250395f Compare May 6, 2025 07:18
@OBorce OBorce force-pushed the feature/api-server-token-nonces branch from bc1e9ed to 45a8920 Compare May 6, 2025 07:27
@OBorce OBorce force-pushed the fix/api-server-burn-output branch from 250395f to 5c332fe Compare May 6, 2025 07:37
@OBorce OBorce marked this pull request as ready for review May 6, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImplOfAnImpl ImplOfAnImpl ImplOfAnImpl approved these changes

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

@azarovh azarovh Awaiting requested review from azarovh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OBorce @ImplOfAnImpl