Minor node GUI visual improvements #1924
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImplOfAnImpl
force-pushed
the
node_gui_visual_improvements
branch
from
2a73540 to
befa818
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the left pane, the account selection row's layout was fixed.
Before, expanded:
and contracted:
After, expanded:
and contracted:
Still not great, but better IMO.
In the "Delegations" panel, the delegations grid had weird spacing:
Before:
After:
This was happening due to a bug in iced_aw, which was fixed in this PR only a couple months ago. This is the reason for using an unreleased version of iced_aw.
Note that for some reason the upgrade also changed how the grid in the "Transactions" panel is rendered, so I had to specify relative
column_widthsfor it explicitly (it still looks a bit different than before though).Because of this I'm not sure whether this PR should be merged right away (but we should probably merge it before our next release anyway).
For testnet wallets, we used to print the legacy maturity period (2000 blocks) in the "Delegations" panel.