Add a wallet command to get the account extended public key #1926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImplOfAnImpl
approved these changes
Jun 5, 2025
Comment on lines
308
to
309
| #[clap(name = "account-extended-public-key")] | ||
| AccountExtendedPublicKey, |
There was a problem hiding this comment.
The order of the enum items here will determine the order of the commands in the help.
So let's put this one near other "account-" commands, preferably sorting them by name.
| Ok(ConsoleCommand::Print(format!( | ||
| "The account extended public key is: {hex_public_key},\n\ | ||
| with chain code: {hex_chain_code}.\n\ | ||
| Or contained in the QR code:\n{qr_code}" |
There was a problem hiding this comment.
This has to be reformulated.
- "The account extended public key is: {hex_public_key}" - this is not the extended public key, it's just the pubic key.
- "Or contained in the QR code" - this sounds broken. Also, it's not clear what is in the code exactly, i.e. how the key and the code are combined together.
As we discussed during the daily, we should probably define a format for a hex-encoded extended public key (e.g. it's always "{hex_public_key}{hex_chain_code}") and then always print it as a single hex string. Then the question "what's in the qr code" won't matter anymore.
P.S.
- should we take
no_qrinto account here as well? - IMO it's better to add the "as-hex" suffix to the command name, even though we don't plan to have a base58 representation for ext keys for now, at least for consistency.
OBorce
force-pushed
the
feature/account-extended-pk
branch
from
3f40979 to
3b78955
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.