Define dockerfile instructions set centrally. #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ernst von Oelsen <[email protected]>
ernstvonoelsen
force-pushed
the
feature-unify-docker-consts
branch
from
e5710d5 to
d285b84
Compare
|
@kcq looks like your automated test pipeline is broken. Prior to committing my branch, I had to install some packages locally (due to the lack of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes-74
What
Centrally defines all supported Docker instructions (and their prefixed forms) inside
/pkg/docker/dockerfile/dockerfile.go; replace usage of currently re-defined consts from/pkg/docker/linter/,/pkg/docker/dockerfile/,/pkg/docker/instruction/instruction.go,/pkg/imagebuilder/imagebuilder.goWhy
How Tested
two unittests added to verify that the upper-/lower-case writing is now correctly covered; at the end via
make test.