An extended and more robust injectScript #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nolaneo changes look fantastic, thanks! Addon version/description etc got lost in package.json after ember-cli upgrade, if you could bring those back then I'll get it merged and a new version released asap. |
nolaneo
force-pushed
the
en/0125-more-robust
branch
from
c081ce2
to
3991f47
Compare
|
Whoops, my bad. Added those back 👌 |
|
Ping |
ctjhoa
reviewed
Sep 7, 2020
| removeListenersAndElement(script); | ||
| reject(error); | ||
| }); | ||
| script.asnyc = true; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
Changes
scriptfrom the DOM after load or failure.