portal-tag-name support to PortForComponent #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o different tags and added tests for this. Removed the ^ from the jquery requirement to fix a bug with ember 1.13 where it wouldn't build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
#6
Commit Msg
Added 'portal-tag-name' feature to portal for to allow for yielding to different tags and added tests for this. Removed the ^ from the jquery requirement to fix a bug with ember 1.13 where it wouldn't build
Notes
I had a hell of a time testing this (though it works). You likely won't have any issues running the tests, but if you clone to a new repo (or just clean out and reinstall your node_modules and bower_components), you'll note that the tests refuse to run due to improper versioning with quint. And, in the opinion of this amerifat yankee wank, It's probably worth fully upgrading to the newest ember-cli sometime in the future as it will make things much easier for new contributors. Cheerio.