Skip to content

Add delete schedule functionality for schedules in the scheduler #3678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 17, 2024
Merged

Add delete schedule functionality for schedules in the scheduler #3678

merged 7 commits into from
Oct 17, 2024

Conversation

jpbruinsslot
Copy link
Contributor

@jpbruinsslot jpbruinsslot commented Oct 14, 2024 •
edited
Loading

Changes

Add a DELETE option for the /schedules endpoint

QA notes

  • Go through the onboarding
  • List the /schedules endpoint
  • Get an id a of a schedule
  • curl -X "DELETE" http://localhost:8004/schedules/[id-here]

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@jpbruinsslot jpbruinsslot added the mula Issues related to the scheduler label Oct 14, 2024
@jpbruinsslot jpbruinsslot self-assigned this Oct 14, 2024
@jpbruinsslot jpbruinsslot marked this pull request as ready for review October 14, 2024 07:50
@jpbruinsslot jpbruinsslot requested a review from a team as a code owner October 14, 2024 07:50
ammar92
ammar92 previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

ammar92
ammar92 reviewed Oct 15, 2024
View reviewed changes
@ammar92
Copy link
Contributor

ammar92 commented Oct 15, 2024

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

  • API endpoint seems to work
    • List the schedules: http get localhost:8004/schedules | jq ".results[].id"
    • Delete one, e.g.: http delete localhost:8004/schedules/8505fc16-e01d-40ac-8d61-69bc7a429863
    • Run the list endpoint again and confirmed that the entry is removed

underdarknl
underdarknl reviewed Oct 16, 2024
View reviewed changes
underdarknl
underdarknl reviewed Oct 16, 2024
View reviewed changes
underdarknl
underdarknl reviewed Oct 16, 2024
View reviewed changes
@jpbruinsslot jpbruinsslot mentioned this pull request Oct 17, 2024
Open
5 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@underdarknl underdarknl merged commit 5dd7d69 into main Oct 17, 2024
20 of 21 checks passed
@underdarknl underdarknl deleted the feature/mula/delete-schedule branch October 17, 2024 09:12
jpbruinsslot added a commit that referenced this pull request Oct 17, 2024
@jpbruinsslot
Merge remote-tracking branch 'origin' into feature/mula/schedules-fil…
5458888 
…ters

* origin:
  Add delete schedule functionality for schedules in the scheduler (#3678)
jpbruinsslot added a commit that referenced this pull request Oct 24, 2024
@jpbruinsslot
Merge branch 'main' into chore/mula/documentation
63b2ad4 
* main: (25 commits)
  Add sterr to output list (#3649)
  feat: ✨ add Shodan InternetDB boefje (#2615)
  Add search endpoint for schedules for scheduler (#3695)
  Fix/report naming (#3666)
  Add delete schedule functionality for schedules in the scheduler (#3678)
  Fix javascript and component template in prod environments (#3672)
  Fix first order dangling affirmation delete (#3682)
  Do not run dh_strip_nondeterminism in Debian packaging (#3674)
  Github action should trigger if workflow definition changes (#3680)
  Updated packages (#3694)
  Silence KATFindingType not found error in JobHandler (#3686)
  Add docs for xtdb analyze bits. (#3688)
  Fix empty vulnerability reports (#3662)
  Fix jsonb 'contained by' query (#3643)
  Add plugins to findings report (#3657)
  Translations update from Hosted Weblate (#3673)
  Update upload_raw.py (#3645)
  Add rocky worker service to debian packages (#3619)
  Fix/yielded objects (#3669)
  make some things look better (#3661)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammar92 ammar92 ammar92 left review comments

@underdarknl underdarknl underdarknl approved these changes

Assignees

@jpbruinsslot jpbruinsslot

Labels
mula Issues related to the scheduler
Projects
KAT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpbruinsslot @ammar92 @underdarknl