Fix/ooi detail fixes #4024
Open
Fix/ooi detail fixes #4024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar92
previously approved these changes
Jan 14, 2025
| <div> | ||
| {% if not ooi|is_finding and not ooi|is_finding_type %} | ||
| {% if not ooi|is_finding and not ooi|is_finding_type %} | ||
| <div> |
There was a problem hiding this comment.
I think this fix (somewhere ish) is intended to ensure that the warning popups are not in multiple columns. This only happens for objects with L0 clearance.
There was a problem hiding this comment.
No, it was meant to remove an empty div if there would be no content.
I'm not sure why the screenshotted widget looks the way it does.
Co-authored-by: stephanie0x00 <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Found a bunch of inconsistencies and missing links / weird labels. Fixed them
QA notes
Please add some information for QA on how to test the newly created code.
Code Checklist
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.