Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update organization_list and settings page, remove unused stuff, add tags + direct settings link #4039

Merged
merged 8 commits into from
Jan 30, 2025

Conversation

underdarknl
Copy link
Contributor

@underdarknl underdarknl commented Jan 21, 2025

Changes

Removes some illogical columns, and adds useful settings links and tags column.

QA notes

My organizations page should still function,
A specific organization page should (if present) now show its tags.

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@underdarknl underdarknl requested a review from a team as a code owner January 21, 2025 14:02
@underdarknl underdarknl changed the title Update organization_list and settings page, remove unused tuff, add tags, diret settings link Update organization_list and settings page, remove unused stuff, add tags + direct settings link Jan 27, 2025
@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

Seems to work.

What doesn't work:

n/a

Bug or feature?:

Identified bug #4055, but not related to this PR.

image

@dekkers dekkers merged commit b1d0530 into main Jan 30, 2025
22 checks passed
@dekkers dekkers deleted the ux/small-changes-to-orgalist branch January 30, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants