Fix delete recipe modal

[madelondohmen]

Changes

If a user tried to delete a recipe, it would always delete the first row of the scheduled reports column.
Also, the delete modal in the second row didn't open.

It was caused by two things:

• The delete-modal didn't have a specific id. This way, the same modal was opened for every row.
• The form inside of the modal didn't have specific id. This way all the hidden input of all different delete-forms was submitted when deleting one item.

@stephanie0x00 found another bug while QA'ing:
After deleting a recipe, if a user tried to rerun this report, an error occured.
Fixed this by checking if the schedule exists. If not, an error message is shown to the user.

Demo

QA notes

Create multiple report rand the try to delete the recipes on the scheduled reports page. Make sure the correct recipes are deleted. Also check if the rerun works as expected and if the warning is clear enough.

---

Code Checklist

• All the commits in this PR are properly PGP-signed and verified.
• This PR only contains functionality relevant to the issue.
• I have written unit tests for the changes or fixes I made.
• I have checked the documentation and made changes where necessary.
• I have performed a self-review of my code and refactored it to the best of my abilities.

• Tickets have been created for newly discovered issues.
• For any non-trivial functionality, I have added integration and/or end-to-end tests.
• I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
• I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

---

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/contributor/templates folder into your comment.

---

Checklist for QA:

Copy-paste the checklist from the docs/source/contributor/templates folder into your comment.

[stephanie0x00]

Checklist for QA:

• I have checked out this branch, and successfully ran a fresh make reset.
• I confirmed that there are no unintended functional regressions in this branch:
  • I have managed to pass the onboarding flow
  • Objects and Findings are created properly
  • Tasks are created and completed properly
• I confirmed that the PR's advertised feature or hotfix works as intended.
• I checked the logs for errors and/or warnings and made issues where necessary

What works:

Scheduling of reports still works.

What doesn't work:

• Deleting a recipe still results in the incorrect recipe to be thrown away.
• After deleting a recipe the interface stops responding in that tab. You have to switch to a different tab to interact with kat again.
• Rerunning a report for which the recipe was deleted throws an error.

Bug or feature?:

• time format bug, but unrelated to this PR and picked up separately. Side effect from Python 3.10 compatibility for datetime parsing in report flow #4302.

[stephanie0x00]

Seems to work now! Interface works after deleting an item. Rerunning a deleted report now gives a nice error to the user and the right recipe is deleted. 🎉

[sonarqubecloud]

Quality Gate failed

Failed conditions
69.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud