Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This is a breaking change
This PR attempts to address two a11y issues with expando-rows:
aria-expanded
state.data-open-label
/data-close-label
behaviour fromexpando-row.js
. This is a breaking change.Online preview: https://manon-expando-row-preview.netlify.app/components/table-expando-row
Screenreader example (NVDA 2024.1 + FF 125.0.3):
Closes #415
BREAKING CHANGE: Remove the
data-open-label
anddata-close-label
attributes from expando-buttons and replace the button label with one that uniquely identifies the contents of the expando-row (e.g. "lorem ipsum details"). Consult the documentation for further accessibility improvements to the epando-rows.