Skip to content

fix: link variant style inheritance #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

fix: link variant style inheritance #817

wants to merge 4 commits into from

Conversation

ppvg
Copy link
Member

@ppvg ppvg commented May 19, 2025

Work in progress.

  • implement configuration stacks (mixins/configurable.scss) in link components
    • link
    • heading link
    • navigation-link
    • header-link
    • header-navigation-link
    • breadcrumb-bar-link
    • footer-link
    • footer-navigation-link
    • header-navigation-collapsible / header-navigation-collapsible-collapsing-element-button
    • header-navigation-button
  • clean up icon mess
    • create inventory of components with directly-configurable pseudo-content icons
    • decide solution direction for ☝️ same
    • do the thing
  • align focus styles
  • add documentation about configurable.scss approach (for internal Manon devs)
  • update documentation for application devs
    • components/link
    • components/icon
    • components/button/icon
    • components/button-to-top

Nice to have?

  • add unit tests for mixins/configurable.scss
  • improve mixin sassdoc

@randh1r
Copy link
Contributor

randh1r commented May 30, 2025

I would like to help with this part, I have created 2 separate issue tickets:

Issue 827

  • add documentation about configurable.scss approach (for internal Manon devs)
  • update documentation for application devs
    • components/link
    • components/icon
    • components/button/icon
    • components/button-to-top

Issue 828

  • add unit tests for mixins/configurable.scss

# Conflicts:
#	manon/breadcrumb-bar.scss
#	manon/link.scss
@randh1r randh1r mentioned this pull request Jun 5, 2025
* fix(linting): fix linting issues

* chore: add tests and update ci workflow

* chore: update sass build

* refactor: use sass-true and vitest (#833)

* refactor: move tests and test script to manon/

* fix: make configurable.is-custom-property private again

* refactor: use sass-true and vitest for sass tests

---------

Co-authored-by: Peter-Paul van Gemerden <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants