Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass vault name and requested password type to askpass process #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tgyurci
Copy link

@tgyurci tgyurci commented Nov 20, 2019

Closes #155

@miquella
Copy link
Owner

Thanks for taking a pass at this, I think it's a good start!

A couple of things that I think could be improved:

  • The VAULTED_PASSWORD_TYPE should probably be a smaller set of values (e.g. MFA token, password, and maybe legacy password; legacy could be captured as part of the disposition below)
  • The disposition/reason for the password should be separate from the password type (e.g. confirmation, passwords didn't match, etc.)
  • These values should be enumerated as const values at the top of steward.go
  • The possible values should be enumerated in the man page

I apologize that it's taken me a while to get back with you, so I understand if you don't have time to continue this work. If you don't have the time, I'll see if I can wrap it up next time I have some time to devote here. 😀

@tgyurci
Copy link
Author

tgyurci commented Oct 14, 2020

I modified the change to match your suggestions. I'm open to any comment especially about the current password type and reason values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass vault name and input type (password, MFA) to askpass
2 participants