More efficient chord validation #378
Merged
+9
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling this change out of PR #377
The chord validator was compiling a monster regexp on each call, which is pretty wasteful. This PR just lifts that regexp precompilation up to the module so it can be reused. I belive this was the main inefficiency behind issue #341 .
There should be no functional changes here, so as long as it passes linting and CI I'm happy to merge.