Build for browser, don't bundle msw #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Im going to say I dont know enough about bundling yet to comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves some problems I was seeing when trying to use the build output in my app. By default, tsup bundles all dependencies in
devDependenciesif they are imported by your code. I thought that it would ignore any specified inpeerDependencies, but that doesn't seem to be the case (I opened egoist/tsup#998 to clarify).So, this explicitly adds
mswto externals, to make sure it's not bundled (we want to use the one installed by the user).I also added the
--platform=browserflag, since we're building for browsers and not node.This also fixes the
mainin package.json, and adds amoduleproperty for legacy tools that don't understandexportsmaps.