Use hasChanges

miraheze · Oct 7, 2024 · 34ad8c5 · 34ad8c5
1 parent 1d77a66
commit 34ad8c5
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/includes/FormFactory/ManageWikiFormFactoryBuilder.php b/includes/FormFactory/ManageWikiFormFactoryBuilder.php
@@ -836,10 +836,10 @@ public static function submissionHandler(
 				throw new InvalidArgumentException( "{$module} not recognised" );
 		}
 
-		if ( $mwReturn->changes ) {
+		if ( $mwReturn->hasChanges() ) {
 			$mwReturn->commit();
 
-			if ( $module != 'permissions' ) {
+			if ( $module !== 'permissions' ) {
 				$mwReturn->logParams['4::wiki'] = $dbName;
 			}
 
@@ -854,7 +854,7 @@ public static function submissionHandler(
 			return [ [ 'managewiki-changes-none' => null ] ];
 		}
 
-		if ( $mwReturn->errors ?? [] && $module == 'permissions' ) {
+		if ( $mwReturn->errors ?? [] && $module === 'permissions' ) {
 			return $mwReturn->errors;
 		}