Make pylint happy

.pylintrc

@@ -156,6 +156,10 @@ disable=R,
   E8731,
   W0232,
   C0415,
+  E9405,
+  E9402,
+  E0599,
+  W1699,
   3rd-party-local-module-not-gated,
   pep8-reserved-keywords
 

salt_sproxy/_roster/ansible.py

@@ -161,9 +161,9 @@ def _get_hosts_from_group(group):
 def _get_hostvars(host):
     hostvars = __context__["inventory"]["_meta"].get("hostvars", {}).get(host, {})
     ret = copy.deepcopy(__opts__.get("roster_defaults", {}))
-    for value in CONVERSION:
-        if value in hostvars:
-            ret[CONVERSION[value]] = hostvars.pop(value)
+    for key, value in CONVERSION.items():
+        if key in hostvars:
+            ret[value] = hostvars.pop(key)
     ret["minion_opts"] = hostvars
     if "host" not in ret:
         ret["host"] = host

salt_sproxy/parsers.py

@@ -2,7 +2,7 @@
 from __future__ import absolute_import
 
 import sys
-import optparse
+import optparse  # pylint: disable=deprecated-module
 import multiprocessing
 
 import salt_sproxy.version
@@ -43,7 +43,7 @@ def dependency_information(include_salt_cloud=False):
     libraries that may be necessary for various Proxy (or Execution) Modules.
     """
     libs = [
-        ("Python", None, sys.version.rsplit("\n")[0].strip()),
+        ("Python", None, sys.version.rsplit("\n", maxsplit=1)[0].strip()),
         ("NAPALM", "napalm", "__version__"),
         ("Netmiko", "netmiko", "__version__"),
         ("junos-eznc", None, jnpr_version),

tox.ini

@@ -22,7 +22,7 @@ deps =
 
 basepython = python3.9
 commands =
-    black --check --skip-string-normalization .
+    black --check .
 
 [testenv:pylint]
 deps =