Update package.json #972
Open
Update package.json #972
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we merge this? |
nikhil233
approved these changes
May 22, 2025
|
If you're running into this issue with npm workspaces, (I have workspace A depends on emoji-mart/react), npm kept installing react@18 inside my workspace's node_modules. I fixed it by deleting the react folder there and also removing the reference to react@18 in my package-lock.json. Super-ugly, will break if i delete package-lock.. but am hoping this gets merged eventually. Having two versions of react installed is a super-confusing "bug" to run into. |
oinochoe
reviewed
Jun 5, 2025
| @@ -19,7 +19,7 @@ | |||
| }, | |||
| "peerDependencies": { | |||
| "emoji-mart": "^5.2", | |||
| "react": "^16.8 || ^17 || ^18" | |||
| "react": "^16.8 || ^17 || ^18 || ^19" | |||
There was a problem hiding this comment.
Does peer dependencies solve everything?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for React 19