Fix index.d.ts by adding missing typings #996
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `shortcodes` was missing from the skins * I also found `search` Both found by analyzing the response from `SearchIndex.search`. Maybe this method however just adds/modifies the types?
This was referenced May 12, 2025
rugk
added a commit
to rugk/awesome-emoji-picker
that referenced
this pull request
May 12, 2025
rugk
added a commit
to rugk/awesome-emoji-picker
that referenced
this pull request
May 12, 2025
|
Apparently, the shortcode is just the ID of the emoji set with added colons ( emoji-mart/packages/emoji-mart/src/config.ts Line 245 in 16978d0 |
|
Any news on this? i really hope for a merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shortcodeswas missing from the skinssearchBoth found by analyzing the response from
SearchIndex.search. Maybe this method however just adds/modifies the types?Ref #576