refactor: paginationの型を明示する#12809
Merged
syuilo merged 3 commits intomisskey-dev:developfrom Dec 26, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12809 +/- ##
===========================================
- Coverage 79.78% 79.76% -0.02%
===========================================
Files 956 956
Lines 108794 108794
Branches 8374 8369 -5
===========================================
- Hits 86800 86781 -19
- Misses 21994 22013 +19 ☔ View full report in Codecov by Sentry. |
Member
|
satisfiesのほうがいいかもしれない? |
Contributor
Author
|
修正しました🙏 |
Member
|
🙏🙏🙏 |
Member
frontend で satisfies は現状使用できない |
Member
|
See #10365 (comment) |
GrapeApple0
added a commit
to GrapeApple0/misskey
that referenced
this pull request
Dec 26, 2023
This reverts commit 6855079.
Merged
Member
|
🤯🤯🤯 |
Contributor
Author
|
satisfiesをasに変えるまたは取り消すprを送った方が良い感じでしょうか? |
Member
|
どのみち computed の type parameter に入れるべきでは |
GrapeApple0
commented
Dec 26, 2023
Comment on lines
83
to
+86
| const featuredPagination = { | ||
| endpoint: 'channels/featured' as const, | ||
| noPaging: true, | ||
| }; | ||
| } satisfies Paging; |
Contributor
Author
There was a problem hiding this comment.
computedでやるとこの部分がエラーを吐いてしまっています(limitがないのでそもそも型的におかしそうですが)
5 tasks
syuilo
pushed a commit
that referenced
this pull request
Dec 27, 2023
madonuko
pushed a commit
to FyraLabs/nyaakey
that referenced
this pull request
Feb 26, 2024
* refactor: paginationの型を明示する * asではなくsatisfiesを使うように
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
paginationプロパティの型を明示しました
Why
paginationの型エラーでエラーを吐いているところが多かったため
Additional info (optional)
Checklist