Add imperative constructs #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this PR ready to be merged? |
|
Good morning,
Yes, the PR is ready, but it does not cover replay for the new
constructs. As Ivan said, I need more time for the replay.
Best,
Pietro Lami
Il 01/05/22 23:27, ivan.lanese ha scritto:
… Hi Juanjo (cc Pietro),
my understanding (Pietro can confirm or correct) is that the PR is
ready but does not cover replay for the new constructs. Do you think
it is fine to push it now, or it is better to also have replay? We
plan to have it, but this may require some time.
Please let me know.
Best,
Ivan
On Sun, 1 May 2022, Juan José González-Abril wrote:
>
> Is this PR ready to be merged?
>
> —
> Reply to this email directly, view it on GitHub, or unsubscribe.
> You are receiving this because you are subscribed to
> thisthread.[AEECYJYBXNBI4RASJZQWCKTVH3GXTA5CNFSM5USUKHLKYY3PNVWWK3TUL52HS4DFVRE
> XG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIJVPYTA.gif] Message ID:
> ***@***.***>
>
>
>
|
|
IMO it would be better to also add support for replaying the new constructs before merging the PR. Please also note that, at the moment, I've put aside my work in this repository since I got a new job. So I may not be able to review the PR as thoroughly as previously. cc. @german-vidal |
|
Hi Juanjo (cc Pietro),
my understanding (Pietro can confirm or correct) is that the PR is
ready but does not cover replay for the new constructs. Do you think it is
fine to push it now, or it is better to also have replay? We plan to have
it, but this may require some time.
Please let me know.
Best,
Ivan
…On Sun, 1 May 2022, Juan José González-Abril wrote:
Is this PR ready to be merged?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to thisthread.[AEECYJYBXNBI4RASJZQWCKTVH3GXTA5CNFSM5USUKHLKYY3PNVWWK3TUL52HS4DFVRE
XG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIJVPYTA.gif] Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added imperative constructs (register, unregister, whereis and registered)
updated send (now you can use also a registered atom (instead of a pid))
added new example
Update elvis.config (see the corresponding commit)