mkfs: Ignore strinop-truncation warning #313
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkfs uses the builtin strncpy, rather than kernel/strings.c, which warns when the `n` is the same size as the destination buffer, as it may not be able to add a NULL byte. This is the desired behavior for directory entry names (which only require a NULL byte if they are shorter than DIRSIZ), so ignore the warning to appease newer GCCs.
Member
|
The current version of gcc doesn't seem to generate this warning. But, I added the attribute((nonstring)) to the dirent struct to document that directory entries may not be null terminated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mkfs uses the builtin
strncpy, rather than kernel/strings.c, which, as of GCC-8, warns whennis the same size as the destination buffer, as it may not be able to add a NULL byte.This is the desired behavior for xv6 directory entry names (which only require a NULL byte if they are shorter than DIRSIZ), but odd for normal uses of strncpy. So just ignore the warning to appease newer GCCs.