Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Reference) Comparing scratch-gui changes for blockly plugins [DO NOT MERGE] #14

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

mayarajan3
Copy link
Collaborator

Resolves

What Github issue does this resolve (please include link)?

  • Resolves #

Proposed Changes

Describe what this Pull Request does

Reason for Changes

Explain why these changes should be made

Test Coverage

Please show how you have added tests to cover your changes

Browser Coverage

Check the OS/browser combinations tested (At least 2)

Mac

  • Chrome
  • Firefox
  • Safari

Windows

  • Chrome
  • Firefox
  • Edge

Chromebook

  • Chrome

iPad

  • Safari

Android Tablet

  • Chrome

gonfunko and others added 28 commits April 19, 2024 08:07
* fix: add support for Scratch-style procedures

* refactor: remove underscore procedure creation callback
* fix: call the new glow methods on ScratchBlocks

* refactor: remove the glowBlock calls
* chore: format blocks.jsx

* feat: plumb Scratch variable support into the UI
* fix: only refresh the toolbox when procedures are created via undo

* chore: add comment clarifying procedure block creation handling
* chore: format blocks.js

* fix: define shadow block colors consistently with scratch-blocks

* refactor: clean up sound menu recording handler
#23)

* chore: format monitor.jsx

* chore: format define-dynamic-block.js

* chore: format make-toolbox-xml.js

* chore: format blockHelpers.js

* chore: format theme definitions

* chore: format custom-procedures.jsx

* fix: use styles instead of colors for coloring dynamic blocks

* refactor: define themes in the format expected by Blockly for BlockStyles

* refactor: convert and inject Scratch themes into Blockly

* chore: add comments clarifying the color/colour dichotomy
…ators (#29)

* refactor: fix compatibility with checkboxes and category status indicators

* chore: remove errant logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants