Fix link to object if it is exposed in __all__
#670
Conversation
…h all modules, use module name of the matched item
There was a problem hiding this comment.
Thank you for the PR! I generally agree that #669 is something we should support. 👍
That being said - we are reaching ugly levels of function complexity here, not sure yet how we can make things simpler. Worst case it just needs more docstrings. I will take a closer look when I have a few cycles. In the meantime, could you please 1) add a snapshot test and 2) a CHANGELOG entry? Thanks!
|
Thanks for looking into it! |
|
Hi! I'm facing the same issue. Unfortunately, this PR seems a bit stale. Do you plan to continue with this? Do you need a hand? |
# Conflicts: # test/testdata/demopackage.html # test/testdata/demopackage_dir.html
|
This PR should be ready for merge |
|
Sorry this took so long! I've finally found some time do do a deep dive here and refactor things a bit. Does this look good to you now? |
|
I just tested it and it looks great, thank you! |
Related issue #669
Search through the possible sources of the module when looking in
all_modules.Also use the path of the matched object.