Skip to content

Revert "Server rendering for homepage, units and topics listing pages" #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

jonkafton
Copy link
Contributor

Reverts #1847

Opening the resource drawer makes a call to re-render the base page that in turn prefetches all of its API content causing the hero image and carousel resources to randomize and side effects including the click handlers lost from resource cards.

This needs to be done before we can merge: https://github.com/mitodl/hq/issues/6163

@jonkafton jonkafton added the Needs Review An open Pull Request that is ready for review label Dec 2, 2024
@jonkafton jonkafton removed the Needs Review An open Pull Request that is ready for review label Dec 2, 2024
@jonkafton jonkafton merged commit 3ffa2cf into main Dec 2, 2024
11 checks passed
@odlbot odlbot mentioned this pull request Dec 5, 2024
12 tasks
@rhysyngsun rhysyngsun deleted the revert-1847-jk/5920-prefetch-homepage branch February 7, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants