fix drawer sticking #1874
Closed
fix drawer sticking #1874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
added
the
Needs Review
Comment on lines
-97
to
-98
| onTransitionExited={removeUrlParams} | ||
| onClose={setOpen.off} |
There was a problem hiding this comment.
In old version, sometimes onTransitionExited was not firing, which meant that the query param never got removed from the URL. Consequently, the effect with dependencies [requiredArePresent, setOpen, requiredParams] would stop firing, and drawer would stay stuck closed.
abeglova
requested changes
Dec 5, 2024
|
I'm going to close this for now. I'm fairly sure that #1872 is going to resolve the original issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Fixes https://github.com/mitodl/hq/issues/6150
Description (What does it do?)
Fixes a bug where the drawer was sticking sometimes—getting stuck in an openable state.
How can this be tested?
mainhomepage: Click a card to open the drawer, then click outside the drawer to close it, and quickly click a different card.?resource=1234is in the URL, but drawer is not open.