Skip to content

align LearningResourceListCard with figma #2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

ChristopherChudzicki
Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki commented Jun 20, 2025

What are the relevant tickets?

Potential followup to #2308

Description (What does it do?)

Aligns mobile version of the search page resource card with Figma. Changes are:

  • minor changes to spacing between header row, title, footer
  • alignment of button icons... now centered on mobile relative to format, start-date

Screenshots (if appropriate):

Branch Mobile vs RC Mobile
Screenshot 2025-06-20 at 3 55 51 PM / Screenshot 2025-06-20 at 3 54 14 PM

Branch Desktop vs RC Desktop (No change)
Screenshot 2025-06-20 at 3 43 21 PM vs Screenshot 2025-06-20 at 3 43 26 PM

How can this be tested?

  1. Check that search page desktop cards are unchanged, search page mobile cards look like screenshot above.
  2. The userlist cards in pages like /dashboard/my-lists/123 are unchanged.

@ChristopherChudzicki ChristopherChudzicki mentioned this pull request Jun 20, 2025
@ChristopherChudzicki ChristopherChudzicki added the Needs Review An open Pull Request that is ready for review label Jun 21, 2025
@mbilalmughal
Copy link

@ChristopherChudzicki @jonkafton The main issue was on the mobile, where the title was causing layout problems. It appears to be resolved now. Thanks a lot! 👍

Copy link
Contributor

@jonkafton jonkafton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing looks much better. Figma does have an 8px gap beneath the title, while we have an 8px top margin on the bottom section that eats into the title a little. I think fixed by giving the title font-size 12px / subtitle3.

image image

@ChristopherChudzicki
Copy link
Contributor Author

ChristopherChudzicki commented Jun 24, 2025

@jonkafton That's odd. The title is already subtitle3 at md and below, and I don't see the margin overlapping the text like it is in your picture.
Screenshot 2025-06-24 at 11 37 59 AM / Screenshot 2025-06-24 at 11 38 02 AM

Re gap vs margin, btw: the spacing (header-body-footer) is uneven on desktop cards, so I think margin is easier (though could change the display style between desktop/margin).

@jonkafton OHHH... I changed the font to subtitle3 on mobile as part of #2308, since that was an issue specifically mentioned in the design QA (whereas this spacing thing wasn't). My screenshot above is after a rebase post-merge, so that explains it.

Copy link
Contributor

@jonkafton jonkafton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ChristopherChudzicki ChristopherChudzicki merged commit e75a260 into main Jun 24, 2025
13 checks passed
@ChristopherChudzicki ChristopherChudzicki deleted the cc/lr-list-card-fixes branch June 24, 2025 16:42
This was referenced Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review An open Pull Request that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants