Conversation
shanbady
approved these changes
Jan 5, 2026
Contributor
shanbady
left a comment
shanbady
left a comment
There was a problem hiding this comment.
LGTM - left a minor comment about missing docstring
|
|
||
| def add_text_query_to_search( | ||
| search, text, search_params, query_type_query, use_hybrid_search | ||
| def add_text_query_to_search( # noqa: PLR0913 |
abeglova
force-pushed
the
ab/pre-filter-neural-query
branch
from
5a33e90 to
0663ce0
Compare
abeglova
added a commit
that referenced
this pull request
Jan 13, 2026
This was referenced Jan 13, 2026
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/9375
Description (What does it do?)
This pr speeds up opensearch hybrid search by moving the search filter into the the neural query. This speeds up the search by reducing the number of records that need to be considered by the neural query
How can this be tested?
follow the instructions in #2808 if you don't have the hybrid search index set up yet
verify that both the regular search and hybrid search (search_mode=hybrid added to the url or selected from the admin searchoptions) works