Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct argument order when invoking httpclient.NewAuthenticatedClient #1

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

tehplague
Copy link
Contributor

The WithAccessToken client option uses the wrong argument order when creating the underlying httpclient. This results in the following error message, since it confuses the header name X-Access-Token and its value:

panic: Get "https://api.mittwald.de/v2/projects": net/http: invalid header field name "[*** MW token redacted ***]"

This PR fixes that.

Copy link
Member

@martin-helmich martin-helmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch. 🤦‍♂️ Good catch, thanks. 👍

@martin-helmich martin-helmich merged commit 338c355 into mittwald:master Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants