Skip to content

refactor(Autocomplete)!: use Option component to define autocomplete … #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

refactor(Autocomplete)!: use Option component to define autocomplete … #1726

merged 1 commit into from
Jul 11, 2025

Conversation

mfal
Copy link
Member

@mfal mfal commented Jul 9, 2025

…options

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025 •
edited
Loading

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 33.99% 7795 / 22933
🔵 Statements 33.99% 7795 / 22933
🔵 Functions 63.65% 606 / 952
🔵 Branches 83.42% 1037 / 1243
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/components/src/components/Autocomplete/Autocomplete.tsx 14.28% 100% 100% 14.28% 30-122
packages/components/src/components/Autocomplete/stories/Default.stories.tsx 0% 100% 100% 0% 2-56
packages/components/src/components/Options/Options.tsx 100% 100% 100% 100%
packages/components/src/components/Popover/Popover.tsx 100% 50% 0% 100%
packages/components/src/components/propTypes/index.ts 100% 100% 100% 100%
packages/components/src/integrations/react-hook-form/components/Field/stories/Autocomplete.stories.tsx 0% 100% 100% 0% 2-74
Generated in workflow #3081 for commit be12a79 by the Vitest Coverage Report Action

@mfal mfal force-pushed the autocomplete-with-options branch from 4f65015 to 80f9d44 Compare July 9, 2025 12:38
@mfal mfal temporarily deployed to github-pages-preview-storybook July 9, 2025 12:38 — with GitHub Actions Inactive
@mfal mfal force-pushed the autocomplete-with-options branch from 80f9d44 to f74e4be Compare July 9, 2025 12:48
@mfal mfal temporarily deployed to github-pages-preview July 9, 2025 12:48 — with GitHub Actions Inactive
@mfal mfal temporarily deployed to github-pages-preview-storybook July 9, 2025 12:48 — with GitHub Actions Inactive
@mfal mfal requested a review from ins0 July 9, 2025 12:53
ins0
ins0 reviewed Jul 9, 2025
View reviewed changes
@mfal mfal force-pushed the autocomplete-with-options branch from f74e4be to a1dd8e9 Compare July 10, 2025 06:45
@mfal mfal temporarily deployed to github-pages-preview July 10, 2025 06:45 — with GitHub Actions Inactive
@mfal mfal temporarily deployed to github-pages-preview-storybook July 10, 2025 06:45 — with GitHub Actions Inactive
@mfal mfal force-pushed the autocomplete-with-options branch from a1dd8e9 to bae2f3e Compare July 10, 2025 06:55
@mfal mfal temporarily deployed to github-pages-preview-storybook July 10, 2025 06:55 — with GitHub Actions Inactive
@mfal mfal temporarily deployed to github-pages-preview July 10, 2025 06:55 — with GitHub Actions Inactive
@mfal mfal temporarily deployed to github-pages-preview-storybook July 10, 2025 07:13 — with GitHub Actions Inactive
@mfal mfal temporarily deployed to github-pages-preview July 10, 2025 07:13 — with GitHub Actions Inactive
@mfal mfal force-pushed the autocomplete-with-options branch from 2e3cd81 to be12a79 Compare July 10, 2025 07:32
@mfal mfal temporarily deployed to github-pages-preview July 10, 2025 07:32 — with GitHub Actions Inactive
@mfal mfal temporarily deployed to github-pages-preview-storybook July 10, 2025 07:32 — with GitHub Actions Inactive
@ins0 ins0 merged commit 9488e41 into main Jul 11, 2025
4 checks passed
@ins0 ins0 deleted the autocomplete-with-options branch July 11, 2025 07:39
@ins0 ins0 mentioned this pull request Jul 11, 2025
Merged
@ins0 ins0 restored the autocomplete-with-options branch July 11, 2025 08:19
@ins0 ins0 temporarily deployed to github-pages-preview July 11, 2025 08:19 — with GitHub Actions Inactive
@ins0 ins0 temporarily deployed to github-pages-preview-storybook July 11, 2025 08:19 — with GitHub Actions Inactive
@ins0
Copy link
Member

ins0 commented Jul 11, 2025

Please reopen, when in use with remote there are still visual bugs, also using the component in the docs - the ui freezes

image

@ins0 ins0 mentioned this pull request Jul 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ins0 ins0 ins0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfal @ins0