use uber gomock #185
Closed
use uber gomock #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR is helpful, could it be reviewed and merged? |
yulin-li
approved these changes
Dec 26, 2023
zalsader
force-pushed
the
use-uber-mockgen
branch
from
5c0b9e9 to
96b629c
Compare
Signed-off-by: Zuhair AlSader <[email protected]>
zalsader
force-pushed
the
use-uber-mockgen
branch
from
96b629c to
ebfdb18
Compare
|
@elenz97 could you please take a look? |
Signed-off-by: Zuhair AlSader <[email protected]>
|
Done by #195 , closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use uber-go/mock instead of golang/mock because the latter is depricated.