-
-
Notifications
You must be signed in to change notification settings - Fork 100
Patch all executables under bin and libexec #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Patch all executables under bin and libexec #920
Conversation
WASM 7z packages don't contain Unix permission information since Qt 6.5.0.
I'm gonna take a look but that is weird, I never had any issue with my WASM builds |
Hi, @Kidev.
What OS are you using? |
I'm on arch kidev:~$ git clone [email protected]:miurahr/aqtinstall.git && cd aqtinstall
kidev:aqtinstall$ python -m venv .venv && source .venv/bin/activate
kidev:aqtinstall(.venv)$ pip install .
kidev:aqtinstall(.venv)$ python --version
Python 3.13.3
kidev:aqtinstall(.venv)$ pip --version
pip 25.0.1 from .venv/lib/python3.13/site-packages/pip (python 3.13)
kidev:aqtinstall(.venv)$ python -m aqt install-qt linux desktop 6.5.0 wasm_singlethread
kidev:aqtinstall(.venv)$ ls -l ./6.5.0/wasm_singlethread/{bin,libexec}
./6.5.0/wasm_singlethread/bin:
.rwxrwxr-x 308 kidev 21 May 19:37 qmake
.rw-rw-r-- 84 kidev 25 Mar 2023 qmake.bat
.rwxrwxr-x 308 kidev 21 May 19:37 qmake6
.rw-rw-r-- 84 kidev 25 Mar 2023 qmake6.bat
.rw-rw-r-- 646 kidev 25 Mar 2023 qt-cmake
.rw-rw-r-- 468 kidev 25 Mar 2023 qt-cmake-private.bat
.rw-rw-r-- 217 kidev 25 Mar 2023 qt-cmake-standalone-test.bat
.rw-rw-r-- 459 kidev 25 Mar 2023 qt-cmake.bat
.rw-rw-r-- 922 kidev 25 Mar 2023 qt-configure-module
.rw-rw-r-- 1.1k kidev 25 Mar 2023 qt-configure-module.bat
.rw-rw-r-- 394 kidev 25 Mar 2023 qt-internal-configure-tests.bat
.rwxrwxr-x 310 kidev 21 May 19:37 qtpaths
.rw-rw-r-- 86 kidev 25 Mar 2023 qtpaths.bat
.rwxrwxr-x 310 kidev 21 May 19:37 qtpaths6
.rw-rw-r-- 86 kidev 25 Mar 2023 qtpaths6.bat
.rw-rw-r-- 246 kidev 21 May 19:37 target_qt.conf
./6.5.0/wasm_singlethread/libexec:
.rw-rw-r-- 3.6k kidev 14 Mar 2023 android_emulator_launcher.sh
.rw-rw-r-- 416 kidev 14 Mar 2023 batchedtestrunner.html
.rw-rw-r-- 6.3k kidev 14 Mar 2023 batchedtestrunner.js
.rw-rw-r-- 4.3k kidev 14 Mar 2023 emrunadapter.js
.rw-rw-r-- 549 kidev 14 Mar 2023 ensure_pro_file.cmake
.rw-rw-r-- 655 kidev 25 Mar 2023 qt-cmake-private
.rw-rw-r-- 1.1k kidev 25 Mar 2023 qt-cmake-private-install.cmake
.rw-rw-r-- 226 kidev 25 Mar 2023 qt-cmake-standalone-test
.rw-rw-r-- 163 kidev 25 Mar 2023 qt-internal-configure-tests
.rw-rw-r-- 17k kidev 14 Mar 2023 qt-testrunner.py
.rw-rw-r-- 12k kidev 25 Mar 2023 qt-wasmtestrunner.py
.rw-rw-r-- 1.7k kidev 14 Mar 2023 qtestoutputreporter.css
.rw-rw-r-- 12k kidev 14 Mar 2023 qtestoutputreporter.js
.rw-rw-r-- 7.3k kidev 14 Mar 2023 qwasmjsruntime.js
.rw-rw-r-- 2.6k kidev 14 Mar 2023 qwasmtestmain.js
.rw-rw-r-- 1.5k kidev 14 Mar 2023 sanitizer-testrunner.py
.rw-rw-r-- 932 kidev 14 Mar 2023 util.js
Same with or without To be fair I always use CMake never qmake that may be why I never saw issues, but afaik the test suite uses qmake. And I don't see issues when I use |
Ah, I see the point. The title of the referenced issue is a bit misleading. "qmake" and "qtpaths" have already been patched, but other scripts, "android_emulator_launcher.sh" in Qt 6.5.0 for example, have not. I'm sorry I didn't do clear writing, please have a look at the code. |
Please note that the referenced issue (jurplel/install-qt-action#227) is old. That issue was created in Feb 2024, while we added the "qmake6", "qtpaths" and "qtpaths6" patches by 00e95c9 in Dec 2024. That's why this PR is a bit confusing. |
Why
An issue in the "jurplel/install-qt-action" project: wasm_singlethreaded/bin all files are non-executable (jurplel/install-qt-action#227).
Update: misleading title. We do have patched "qmake", but unpatched other scripts (executables).
Test the packages themselves
Qt 6.3.2
https://download.qt.io/online/qtsdkrepository/linux_x64/desktop/qt6_632_wasm/qt.qt6.632.wasm_32/6.3.2-0-202209072004qtbase-Linux-openSUSE_15_3-GCC-Linux-WebAssembly-X86_64.7z
Package details of Qt 6.3.2
Fine.
Qt 6.5.0
https://download.qt.io/online/qtsdkrepository/linux_x64/desktop/qt6_650_wasm_singlethread/qt.qt6.650.wasm_singlethread/6.5.0-0-202303290841qtbase-Windows-Windows_10_22H2-Clang-Windows-WebAssembly-X86_64.7z
Package details of Qt 6.5.0
Missing "x"es.
Qt 6.8.3
https://download.qt.io/online/qtsdkrepository/all_os/wasm/qt6_683/qt6_683_wasm_singlethread/qt.qt6.683.wasm_singlethread/6.8.3-0-202503201334qtbase-Windows-Windows_10_22H2-Clang-Windows-WebAssembly-X86_64.7z
Package details of Qt 6.8.3
Missing "x"es, too.
As you can see, WASM 7z packages don't contain Unix permission information since Qt 6.5.0.
Fix and test
Qt 6.3.2, 6.5.0 and 6.8.3.
File info of installed Qt's
Now all shell scripts are executable.