Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed data was truncated on a property value longer than 255 chars #451

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

andy1xx8
Copy link

Hi.
If the data is longer than 255 characters (hardcoded in the source code), it will be truncated.
This is a really serious problem because the URL from Google Ads is longer than 255 and was mentioned here #405

Therefore, this pull request will allow you to specify this limitation via config while constructing the mix panel tracking lib.

@andy1xx8
Copy link
Author

@tdumitrescu could u please help me to review this PR :3

@tdumitrescu
Copy link
Member

Have you tried running this locally for yourself? AFAIK there is still a server-side 255-char limit on string properties, so if you're trying to grab values out of a long URL with custom properties, you may need to do this on the client side and parse important params out of the URL yourself before sending (the way this SDK does for common UTM params and IDs).

@andy1xx8 andy1xx8 closed this Oct 25, 2024
@andy1xx8 andy1xx8 reopened this Oct 25, 2024
@andy1xx8
Copy link
Author

andy1xx8 commented Nov 4, 2024

Have you tried running this locally for yourself? AFAIK there is still a server-side 255-char limit on string properties, so if you're trying to grab values out of a long URL with custom properties, you may need to do this on the client side and parse important params out of the URL yourself before sending (the way this SDK does for common UTM params and IDs).

Hi, I can't parse the URL, get the params and cut it off for 255 characters cause:

  • want to keep the original URL as it is
  • There is no way to form up the original URL if it was truncated
  • I ( maybe many others) am using this client library and building a custom server-side API => So a custom server-side can handle this. Moreover, I think this client tracking lib should have the ability to change the maximum character length flexible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants