ci: lint on push to prevent code style issues
#454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamirmahal
force-pushed
the
ci/npm-run-lint-on-push-to-help-prevent-codebase-regressions
branch
from
2d5ff0c
to
ce776f1
Compare
tdumitrescu
reviewed
Oct 23, 2024
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - run: npm ci | ||
| - run: npm run lint |
There was a problem hiding this comment.
this is already run as part of npm test:
Line 21 in 475b2c6
There was a problem hiding this comment.
Ah, I missed that. Do you want to remove npm run lint from the test script? I think it's a bit unexpected.
Feel free to close this pull request if there are no changes here that you like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #453.