issue #48 - fix chat in pidgin client #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
- Coverage 67.97% 67.93% -0.05%
==========================================
Files 48 48
Lines 4550 4550
==========================================
- Hits 3093 3091 -2
- Misses 1252 1253 +1
- Partials 205 206 +1 ☔ View full report in Codecov by Sentry. |
This commit implements the following changes that makes Pidgin chat work: - chat detail level value must be "2" - set TLV 0xDA in chat room info - change the chat cookie to this format: %s-%s-%s, where the third %s is the chat room name. Co-authored-by: Josh Knight <[email protected]>
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the following changes that makes Pidgin chat work: